[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625075#action_12625075
]
Shalin Shekhar Mangar commented on SOLR-716:
--------------------------------------------
bq. So I can define properties in a core scope based on properties defined in
the core-container scope. Seems like a natural & expected feature.
I've been thinking more on this. The core scope already inherits all properties
defined in container scope. You can also override them. The only thing which is
not possible is having expressions in the attributes of the <core> node such as
name, instanceDir etc. Is that really necessary? If you enable expressions in a
file whose information can be modified at run-time then it becomes a bit more
complicated to persist back. You'd need to track both expressions and keep
their evaluated values separately instead of just one object.
I feel that this discussion should not hold up the 1.3 release any more. Let us
go ahead with the patch I posted and handle enhancements as part of SOLR-646
with 1.3.1 or 1.4 which ever comes first.
> Support properties in configuration files
> -----------------------------------------
>
> Key: SOLR-716
> URL: https://issues.apache.org/jira/browse/SOLR-716
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: solr-716.patch, SOLR-716.patch, SOLR-716.patch
>
>
> Initially suggested by Hoss at
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
> and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
> <property name="var" value="value" />
> <cores adminPath="/admin/cores">
> <core name="core0" instanceDir="core0">
> <property name="var" value="value" />
> </core>
> <core name="core1" instanceDir="core1" />
> </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order --
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is
> (without evaluation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
