[
https://issues.apache.org/jira/browse/SOLR-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627035#action_12627035
]
Henri Biestro commented on SOLR-731:
------------------------------------
The issue is about having public access from CD to the CC.
I think that it would be misleading to other contributors to believe the CD is
more than a parameter passing facility; it should not be used beyond core
creation.
Removing the SC->CD reference altogether is a strawman feature (at least, I
know why this code should not not make it to the trunk).
But it illustrates the point that this reference is not functionally needed
since all information vehicled though the CD is exploited then stored elsewhere.
As you mentioned, CoreDescriptor/CoreContainer/SolrCore are intertwined so it
is hard to cut those in pieces as I've been asked to do.
For all intent & purpose, SOLR-725 related issues are resolved in the SOLR-725
attached patch.
> CoreDescriptor.getCoreContainer should not be public
> ----------------------------------------------------
>
> Key: SOLR-731
> URL: https://issues.apache.org/jira/browse/SOLR-731
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Henri Biestro
> Attachments: solr-731.patch
>
>
> For the very same reasons that CoreDescriptor.getCoreProperties did not need
> to be public (aka SOLR-724)
> It also means the CoreDescriptor ctor should not need a CoreContainer
> The CoreDescriptor is only meant to be describing a "to-be created SolrCore".
> However, we need access to the CoreContainer from the SolrCore now that we
> are guaranteed the CoreContainer always exists.
> This is also a natural consequence of SOLR-647 now that the CoreContainer is
> not a map of CoreDescriptor but a map of SolrCore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
