[ 
https://issues.apache.org/jira/browse/SOLR-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627253#action_12627253
 ] 

Mark Miller commented on SOLR-743:
----------------------------------

enums are shorter, clearer, and safer. if under 64 options, they are 
represented by a long and set operations are done with bitwise arithmetic, so 
while its going to be a bit slower, if its measurable I'd be pretty surprised 
(though I guess I'll be happy to measure). Some programmers still cling to 
bitsets, but I buy Josh Blochs arguments that the bitset is better left behind 
in favor of the enum - its just better code. I'll go with whatever the 
community wants though - this patch just presents an option.

- Mark

> Update the bitset usage in Schema to enums
> ------------------------------------------
>
>                 Key: SOLR-743
>                 URL: https://issues.apache.org/jira/browse/SOLR-743
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-743.patch
>
>
> For all of the reasons given by smarter people than I (specifically, 
> Effective Java), and because its just easier to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to