[
https://issues.apache.org/jira/browse/SOLR-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628036#action_12628036
]
Wojtek Piaseczny commented on SOLR-748:
---------------------------------------
A more detailed list of changes:
ShardFacetCount, DistribFieldFacet, and FacetInfo classes become final public.
Their member variables become private, and are accessible (get & set) through
public accessors.
FieldFacet becomes a public class. Its member variables become protected, and
are accessible (get & set) through public accessors.
ResponseBuilder's private member variable _facetInfo renamed to facetInfo and
made public.
FacetComponent uses public accessors to access class members.
> FacetComponent helper classes are package restricted
> ----------------------------------------------------
>
> Key: SOLR-748
> URL: https://issues.apache.org/jira/browse/SOLR-748
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Wojtek Piaseczny
> Fix For: 1.4
>
> Attachments: 748.patch
>
>
> Original discussion:
> http://www.nabble.com/Package-Access-Issues---Extending-FacetComponent-to19148122.html
> The FacetComponent class uses several helper classes that currently have
> package-restricted access. This makes it impossible to extend the
> FacetComponent without rewriting most of its functionality.
> A proposed solution is to make those classes public and make their public
> member variables accessibly only through get and set functions (i.e. make
> them private).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
