[ 
https://issues.apache.org/jira/browse/SOLR-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629160#action_12629160
 ] 

Mark Miller commented on SOLR-743:
----------------------------------

bq. Although it is slower (which doesn't surprise me), does it really matter?

Right...of course its going to be slower, but my guess was that it was slower 
in a way that compiler/hotspot optimizations, nature of the code, etc, would 
make the difference not really matter (its what effective java seemed to 
indicate, and since he wrote the code..). 

But the results yonik posted...if thats the slowdown, I don't see moving as an 
option...and if we were using enums I'd vote for a switch to bitset. Seems like 
quite a difference to me (though I still havn't had time to educate myself with 
the test code used).



> Update the bitset usage in Schema to enums
> ------------------------------------------
>
>                 Key: SOLR-743
>                 URL: https://issues.apache.org/jira/browse/SOLR-743
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-743.patch, SOLR-743.patch
>
>
> For all of the reasons given by smarter people than I (specifically, 
> Effective Java), and because its just easier to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to