[ 
https://issues.apache.org/jira/browse/SOLR-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645390#action_12645390
 ] 

Noble Paul commented on SOLR-835:
---------------------------------

bq.Attempting to save that allocation in the context of a complete 
request/response over the network perhaps isn't worth it?

Yes , it is cheap but the point is we can avoid it. 
It creates a new Object of CommonsHttpSolrServer, BinaryResponseParser, URL, 
String concatenation and if a take a look at the constructor of  
{code}
public CommonsHttpSolrServer(URL baseURL, HttpClient client, ResponseParser 
parser, boolean useMultiPartPost)   
{code}
it is doing so many string operations etc.

Considering the fact that the shards are always going to be few and constant 
over the life of a server this looked bad to me.

> reduce Object creation in SearchHandler
> ---------------------------------------
>
>                 Key: SOLR-835
>                 URL: https://issues.apache.org/jira/browse/SOLR-835
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>         Attachments: SOLR-835.patch
>
>
> CommonsHttpSolrServer is threadsafe . why create one for every request?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to