[ 
https://issues.apache.org/jira/browse/SOLR-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647034#action_12647034
 ] 

Mark Miller commented on SOLR-465:
----------------------------------

bq. But couldn't one start the container with the appropriate system property 
pointing to the new NIOFSDirectory class and "turn on" NIOFSDirectory (or any 
other Directory) that way?

Yes. Thats why I say its not really broken.  It will still work, and you can 
still change the impl...but the code implies you will get the right impl for 
the right OS, and you won't without using that system property. Hoping to make 
that pain go away.

bq. Why not specify in solrconfig.xml?

Possibly...I think automatic has a lot of allure though...

bq. Is it possible to use RAMDirectory too?

The factory returns a Directory, so it is in that sense...it may have other 
ramifications though depending on what solr assumes. Don't know off hand.

> Add configurable DirectoryProvider so that alternate Directory 
> implementations can be specified via solrconfig.xml
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-465
>                 URL: https://issues.apache.org/jira/browse/SOLR-465
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 1.3
>            Reporter: TJ Laurenzo
>             Fix For: 1.4
>
>         Attachments: SOLR-465.patch, SOLR-465.patch, 
> solr-directory-provider.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Solr is presently hard-coded to use the FSDirectory implementation in Lucene. 
>  Other Directory implementations are possible.  This patch creates a new 
> DirectoryProvider interface and extends SolrCore to load an implementation of 
> it from solrconfig.xml (if specified).  If not specified, then it will 
> fallback to the FSDirectory.
> A DirectoryProvider plugin can be configured in solrconfig.xml with the 
> following XML:
>    <directoryProvider class="class.name">
>       <!-- Parameters as required by the implementation -->
>    </directoryProvider>
> This patch was created against solr trunk checked out on 11/20/2007.  Most of 
> it is new code and should apply cleanly or with minor relocation.  If it does 
> not, let me know and I will update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to