[
https://issues.apache.org/jira/browse/SOLR-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654213#action_12654213
]
Yonik Seeley commented on SOLR-781:
-----------------------------------
Lars, I already committed some code to normalize on the new facet.sort values
so we don't need to check for both new and legacy everywhere.
Also, you didn't miss those string constants - I removed those two cases since
they were being used for the wrong variable (facet=true/false instead of
facet.sort=true/false). Wrong context makes the code more confusing.
> Change facet.sort from boolean to string and specify sort method explicitely
> ----------------------------------------------------------------------------
>
> Key: SOLR-781
> URL: https://issues.apache.org/jira/browse/SOLR-781
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-781.patch, SOLR-781.patch, SOLR-781.patch,
> SOLR-781.patch
>
>
> The facet.sort parameter is currently a boolean, which has some downsides as
> explained in http://www.nabble.com/facet.sort-parameter-td19570834.html
> Changing it to a string which explicitely states the sort method would
> address these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
