[ 
https://issues.apache.org/jira/browse/SOLR-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658743#action_12658743
 ] 

David Bowen commented on SOLR-925:
----------------------------------

-1 on this patch.  If you try this example (using the example as in ant 
run-example):

<add><doc>
  <field name="id">Test for Highlighting StringIndexOutOfBoundsExcdption</field>
  <field name="name">Some Name</field>
  <field name="manu">Acme, Inc.</field>
  <field name="features">Description of the features, mentioning various 
things</field>
  <field name="features">Features also is multivalued</field>
  <field name="popularity">6</field>
  <field name="inStock">true</field>
</doc></add>

then this url

http://localhost:8983/solr/select/?q=features&hl=true&hl.snippets=2&hl.fl=features&hl.fragsize=0

shows correct highlighting in the first snippet, but highlighting is shifted 
right about 19 characters in the second.



> Highlighter doesn't work on a field which is multiValued="true" and 
> termOffsets="true"
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-925
>                 URL: https://issues.apache.org/jira/browse/SOLR-925
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 1.3
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-925.patch
>
>
> This seems to be introduced at r674677.
> {panel}
> java.lang.StringIndexOutOfBoundsException: String index out of range: 15
>       at java.lang.String.substring(Unknown Source)
>       at 
> org.apache.lucene.search.highlight.Highlighter.getBestTextFragments(Highlighter.java:239)
>       at 
> org.apache.solr.highlight.DefaultSolrHighlighter.doHighlighting(DefaultSolrHighlighter.java:310)
>       at 
> org.apache.solr.handler.component.HighlightComponent.process(HighlightComponent.java:83)
>       at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:171)
>       at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:131)
>       at org.apache.solr.core.SolrCore.execute(SolrCore.java:1313)
>       at 
> org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:303)
>       at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:232)
>       at 
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1089)
>       at 
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:365)
>       at 
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
>       at 
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
>       at 
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:712)
>       at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
>       at 
> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:211)
>       at 
> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
>       at 
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:139)
>       at org.mortbay.jetty.Server.handle(Server.java:285)
>       at 
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:502)
>       at 
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:821)
>       at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
>       at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:208)
>       at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:378)
>       at 
> org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:226)
>       at 
> org.mortbay.thread.BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
> {panel}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to