I'm not sure if this is the place to ask, so please feel free to correct me if I'm completely wrong.

I've been using Lucene for about three years or so now, and Solr for about 6 months or so. I really love what you guys are doing for the community and I would like to help in whatever way I can. I asked on the solr list about maybe it would be nice to have SolrJ support for handling the term vector component responses in a similar fashion to how facets are treated today, and thought that I could help by adding this functionality. Since I'm new to contributing (yes I have read the wiki etc, so I know the basics), but I just wanted to ask a few things:

- Regarding naming conventions, do you always use the _privateVariable vs. parameterVariable naming? - When testing, I figured that I would add my tests to the SolrExampleTests.java class, so that I can run them against embedded solr, jetty etc etc. Is that the correct approach? - Specifically for my contribution, dealing with the term vector response handler, is it okay to use something like:
 query.set(CommonParams.QT, "tvrh");
in the test? or is this bad? i just figured that you dont want such parameters forced into the SolrQuery class... or? What do you all suggest? for highlighting and facets its straigtforward since you don't need to set any QT, and you can just say solrQuery.setHighlight(true); etc. But i guess it might be bad to force the handler into the SolrQuery class, if someone decides to not register the handler in their solrconfig.xml... Any thoughts here?

And how "done" should my patch be before i add it to jira?

Thanks, and sorry for all the "newbie" questions...

Best regards,
 Aleksander


--
Aleksander M. Stensby
Senior software developer
Integrasco A/S
www.integrasco.no

Please consider the environment before printing all or any of this e-mail

Reply via email to