[ 
https://issues.apache.org/jira/browse/SOLR-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667314#action_12667314
 ] 

Kay Kay commented on SOLR-974:
------------------------------

| Note - the onImportEnd event listener is still invoked even if no documents 
were created and commit was skipped. I think that is alright.

Is there anything in the Context object that says that the no documents were 
created and commit was skipped. Otherwise - onImportEndListener would continue 
to execute even if in reality no documents were imported then, that is not so 
useful. 

> DataImportHandler should not commit if no data has been updated
> ---------------------------------------------------------------
>
>                 Key: SOLR-974
>                 URL: https://issues.apache.org/jira/browse/SOLR-974
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: Wojtek Piaseczny
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-974.patch, SOLR-974.patch
>
>
> The DataImportHandler always finishes an import with a commit, even if it 
> retrieved no data from its data source. Add a short circuit to not commit if 
> no data was imported.
> Related discussion:
> http://www.nabble.com/Performance-Hit-for-Zero-Record-Dataimport-td21572935.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to