[ 
https://issues.apache.org/jira/browse/SOLR-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672571#action_12672571
 ] 

Koji Sekiguchi commented on SOLR-670:
-------------------------------------

Thank you guys. I didn't recall why I didn't set writer=null in the finally 
block when I wrote the first patch... I'd like to try Shalin's patch, but I 
couldn't apply it:

{noformat}
[k...@macbook SOLR-670]$ patch -p0 --dry-run < SOLR-670.patch 
patching file src/test/org/apache/solr/update/DirectUpdateHandlerTest.java
Hunk #1 FAILED at 173.
Hunk #2 FAILED at 183.
Hunk #3 FAILED at 229.
Hunk #4 FAILED at 236.
4 out of 4 hunks FAILED -- saving rejects to file 
src/test/org/apache/solr/update/DirectUpdateHandlerTest.java.rej
patching file src/java/org/apache/solr/update/DirectUpdateHandler2.java
{noformat}


> UpdateHandler must provide a rollback feature
> ---------------------------------------------
>
>                 Key: SOLR-670
>                 URL: https://issues.apache.org/jira/browse/SOLR-670
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-670.patch, SOLR-670.patch, SOLR-670.patch, 
> SOLR-670.patch
>
>
> Lucene IndexWriter already has a rollback method. There should be a 
> counterpart for the same in _UpdateHandler_  so that users can do a rollback 
> over http 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to