> is this really true?

I think it is true. Unfortunately I didn't have time to write test for it, but I
tested it by manual when I committed it... Do you see it doesn't work?

Koji

Chris Hostetter wrote:
: : +29. SOLR-976: deleteByQuery is ignored when deleteById is placed prior to deleteByQuery in a <delete>.
: +    Now both delete by id and delete by query can be specified at the same 
time as follows. (koji)
: +      <delete>
: +        <id>05991</id><id>06000</id>
: +        <query>office:Bridgewater</query><query>office:Osaka</query>
: +      </delete>
: +

is this really true? the patch only modifies XMLLoader, but don't DeleteUpdateCommand and RunUpdateProcessor also need to be changed to make this work ... there's was no test commited with this patch so i'm not convinced, and i see this code in RunUpdateProcessor...

    if( cmd.id != null ) {
      updateHandler.delete(cmd);
    }
    else {
      updateHandler.deleteByQuery(cmd);
    }



-Hoss



Reply via email to