[
https://issues.apache.org/jira/browse/SOLR-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675117#action_12675117
]
Kay Kay commented on SOLR-967:
------------------------------
The revised patch looks ok to me.
> NamedList - Deprecating ctor. with heterogenous List and replacing with a
> type-safe variant.
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-967
> URL: https://issues.apache.org/jira/browse/SOLR-967
> Project: Solr
> Issue Type: Improvement
> Environment: Java 6, Tomcat 6
> Reporter: Kay Kay
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-967.patch, SOLR-967.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> NamedList (org/apache/solr/common/util/NamedList ) currently has a
> heterogenous List (even numbered indices are String-s ) and the odd-numbered
> indices are the specific types. As per benchmarks ( see SOLR-912 ) - the
> implementation could be improved in favor of a Map.Entry<String, T> that
> beats in performance and ease of code maintenance.
> As per the discussion in SOLR-912 , a separate issue in JIRA is created that
> temporarily deprecates the List ctor. in NamedList and replaces the same with
> a Map.Entry<String, T> [] arg. constructor .
> This would be go in 1.4 to enable people to migrate their code for the new
> ctor. and move away from List<?> .
> At a later version of Solr (may be v2) - the optimal implementation would be
> brought back in with the List <Map.Entry<String, ?> > for better type-safety
> and performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
