[
https://issues.apache.org/jira/browse/SOLR-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676136#action_12676136
]
Hoss Man commented on SOLR-844:
-------------------------------
I still think the javadocs should be beefed up a bit... at a minimum the info
from "When to use this ?", "How does the Load Balancing happen ?", and "How
does it know if a server has come back up ?" sections of the wiki page Noble
made should be in the class level javadocs ... some of the "How does it
know..." info made it into the javadocs for setAliveCheckInterval, but
considering how important that method is there should be a ref to it in the
class docs -- and there *definitely* needs to be some explicit mention of the
"The ping is done not in a separate thread, it is done in a thread which made a
normal request." fact, i would *never* have guessed that looking at the public
docs in the class.
And as I mentioned before: if there are concerns that this class will be
misused (and it certainly seems like there are) then it really needs to contain
javadocs explaining when it *doesn't* make sense to use it and some alternative
suggestions (if nothing else, a link to wikipedia:
[http://en.wikipedia.org/wiki/Load_balancing_(computing)])
> A SolrServer impl to front-end multiple urls
> --------------------------------------------
>
> Key: SOLR-844
> URL: https://issues.apache.org/jira/browse/SOLR-844
> Project: Solr
> Issue Type: New Feature
> Components: clients - java
> Affects Versions: 1.3
> Reporter: Noble Paul
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.4
>
> Attachments: SOLR-844.patch, SOLR-844.patch, SOLR-844.patch,
> SOLR-844.patch, SOLR-844.patch
>
>
> Currently a {{CommonsHttpSolrServer}} can talk to only one server. This
> demands that the user have a LoadBalancer or do the roundrobin on their own.
> We must have a {{LBHttpSolrServer}} which must automatically do a
> Loadbalancing between multiple hosts. This can be backed by the
> {{CommonsHttpSolrServer}}
> This can have the following other features
> * Automatic failover
> * Optionally take in a file /url containing the the urls of servers so that
> the server list can be automatically updated by periodically loading the
> config
> * Support for adding removing servers during runtime
> * Pluggable Loadbalancing mechanism. (round-robin, weighted round-robin,
> random etc)
> * Pluggable Failover mechanisms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
