[ 
https://issues.apache.org/jira/browse/SOLR-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herb Jiang updated SOLR-1053:
-----------------------------

    Description: 
It will got excexception when the size of data-config.xml are times of 
1024bytes.
Maybe it should check the sz==-1 when in.read(buf) reach the EOF.

{noformat}
#### ORIGINAL CODE ####
static String getResourceAsString(InputStream in) throws IOException {
    ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
    byte[] buf = new byte[1024];
    int sz = 0;
    try {
      while (true) {
        sz = in.read(buf);
        
        baos.write(buf, 0, sz);
        if (sz < buf.length)
          break;
      }
    } finally {
      try {
        in.close();
      } catch (Exception e) {

      }
    }
    return new String(baos.toByteArray());
  }

  was:
It will got excexception when the size of data-config.xml are times of 
1024bytes.
Maybe it should check the sz==-1 when in.read(buf) reach the EOF.


#### ORIGINAL CODE ####
static String getResourceAsString(InputStream in) throws IOException {
    ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
    byte[] buf = new byte[1024];
    int sz = 0;
    try {
      while (true) {
        sz = in.read(buf);
        
        baos.write(buf, 0, sz);
        if (sz < buf.length)
          break;
      }
    } finally {
      try {
        in.close();
      } catch (Exception e) {

      }
    }
    return new String(baos.toByteArray());
  }


> SolrWriter.getResourceAsString IndexOutOfBounceException
> --------------------------------------------------------
>
>                 Key: SOLR-1053
>                 URL: https://issues.apache.org/jira/browse/SOLR-1053
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: All
>            Reporter: Herb Jiang
>
> It will got excexception when the size of data-config.xml are times of 
> 1024bytes.
> Maybe it should check the sz==-1 when in.read(buf) reach the EOF.
> {noformat}
> #### ORIGINAL CODE ####
> static String getResourceAsString(InputStream in) throws IOException {
>     ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
>     byte[] buf = new byte[1024];
>     int sz = 0;
>     try {
>       while (true) {
>         sz = in.read(buf);
>         
>         baos.write(buf, 0, sz);
>         if (sz < buf.length)
>           break;
>       }
>     } finally {
>       try {
>         in.close();
>       } catch (Exception e) {
>       }
>     }
>     return new String(baos.toByteArray());
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to