[
https://issues.apache.org/jira/browse/SOLR-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693871#action_12693871
]
Grant Ingersoll commented on SOLR-663:
--------------------------------------
Shalin,
I'm not sure I am following the logic in this patch, specifically around:
{code}
java.io.File keepWordsFile = new File(wordFiles);
if (keepWordsFile.exists()) {
List<String> wlist = loader.getLines(wordFiles);
words = StopFilter.makeStopSet(
(String[])wlist.toArray(new String[0]), ignoreCase);
} else {
List<String> files = StrUtils.splitFileNames(wordFiles);
for (String file : files) {
List<String> wlist = loader.getLines(file.trim());
words.addAll(StopFilter.makeStopSet((String[])wlist.toArray(new
String[0]), ignoreCase));
}
{code}
When is the if clause above executed? Seems like the most likely case is that
people are just using a file in solr/conf and it is relative, so the exists()
method call will never be true, since the current working directory is likely
to be two levels up?
Also, why the need for separate cases anyway? Isn't the single file case just
a degenerate case of the multiple files version?
See also SOLR-1095, where I am working on some fixes to this, but I want to
make sure I capture your understanding first.
> Allow multiple files for stopwords, protwords and synonyms
> ----------------------------------------------------------
>
> Key: SOLR-663
> URL: https://issues.apache.org/jira/browse/SOLR-663
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-663.patch
>
>
> Allow multiple files separated by comma (escaped by backslash) for
> StopFilterFactory, EnglishPorterFilterFactory, KeepWordFilterFactory and
> SynonymFilterFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
