[ 
https://issues.apache.org/jira/browse/SOLR-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700626#action_12700626
 ] 

Uri Boness commented on SOLR-1099:
----------------------------------

Basically that was the original idea, but since then a few things were added. 

I thought it would be nice to have the same features provided by the 
{{FieldAnalysisRequestHandler}} in the {{AnalysisRequestHnalder}}, so the 
latest patch does the following:

- The {{FieldAnalysisRequestHandler}} accepts a query, a value, and field 
names/types to work on. It will then return the analysis breakdown for each 
field name/type. It is also possible to send a {{showmatch}} param to "mark" 
the field tokens that match the query tokens (just like you have in the 
analysis.jsp)
- The current/old {{AnalysisRequestHandler}} is deprecated in favour of a new 
class -> {{DocumentAnalysisRequestHandler}}
- The new {{DocumentARH}} acts on sent documents (just like the old ARH) only 
that it also support {{query}}  and {{showmatche}} parameters
- The reason I didn't apply this logic directly to the 
{{AnalysisRequestHandler}} is to be consistent with the naming here -> 
{{DocumentARH}} vs. {{FieldARH}} (and it's a more descriptive name now that we 
have yet another analysis request handler)
- Both the {{FieldARH}} and the {{DocumentARH}} inherit from the same base 
class - so they can share common functionality (e.g. rendering of the analysis 
breakdown)


> FieldAnalysisRequestHandler
> ---------------------------
>
>                 Key: SOLR-1099
>                 URL: https://issues.apache.org/jira/browse/SOLR-1099
>             Project: Solr
>          Issue Type: New Feature
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: AnalisysRequestHandler_refactored.patch, 
> AnalysisRequestHandler_refactored1.patch, 
> FieldAnalysisRequestHandler_incl_test.patch
>
>
> The FieldAnalysisRequestHandler provides the analysis functionality of the 
> web admin page as a service. This handler accepts a filetype/fieldname 
> parameter and a value and as a response returns a breakdown of the analysis 
> process. It is also possible to send a query value which will use the 
> configured query analyzer as well as a showmatch parameter which will then 
> mark every matched token as a match.
> If this handler is added to the code base, I also recommend to rename the 
> current AnalysisRequestHandler to DocumentAnalysisRequestHandler and have 
> them both inherit from one AnalysisRequestHandlerBase class which provides 
> the common functionality of the analysis breakdown and its translation to 
> named lists. This will also enhance the current AnalysisRequestHandler which 
> right now is fairly simplistic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to