equals method should compare this and other of DocList in DocSetBase
--------------------------------------------------------------------

                 Key: SOLR-1207
                 URL: https://issues.apache.org/jira/browse/SOLR-1207
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 1.3, 1.2, 1.1.0, 1.4
            Reporter: Koji Sekiguchi
            Priority: Minor
             Fix For: 1.4


There is a fault in equals method of DocSetBase class:

{code}
if (this instanceof DocList && other instanceof DocList) {
  // compare ordering
  DocIterator i1=this.iterator();
  DocIterator i2=this.iterator();       // <== *this should be other*
  while(i1.hasNext() && i2.hasNext()) {
    if (i1.nextDoc() != i2.nextDoc()) return false;
  }
  return true;
  // don't compare matches
}
{code}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to