[
https://issues.apache.org/jira/browse/SOLR-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721879#action_12721879
]
Hoss Man commented on SOLR-1167:
--------------------------------
I like the simplicity of the patch, and the use of an existing standard. If
I'd realized that xinclude was supported by DocumentBuilderFactory i would have
tried this a long time ago ... my only concern is how well supported this
feature is in the various DBF impls out there.
BTW: the redundent snippets in DataImporter.java and COnfig.java make me think
we need to refactor a helper function for this somewhere in utils, but that's
not a huge issue.
bq. Is there a way to conditionally include one file or another (rather than
include the other if one is not available)?
Keep in mind that the problem can be inverted: instead of having a common
solrconfig.xml file that conditionally includes master-snippet.xml or
slave-snippet.xml based on some property, you can have unique solrconfig.xml
files for the master and slave (in separate solr home dirs) which only contain
the unique options and include the common chunks from other files .. then you
can use solr.solr.home to drive which set of configs to use.
> Support module xml config files using XInclude
> ----------------------------------------------
>
> Key: SOLR-1167
> URL: https://issues.apache.org/jira/browse/SOLR-1167
> Project: Solr
> Issue Type: New Feature
> Reporter: Bryan Talbot
> Priority: Minor
> Attachments: SOLR-1167.patch, SOLR-1167.patch
>
>
> Current configuration files (schema and solrconfig) are monolithic which can
> make maintenance and reuse more difficult that it needs to be. The XML
> standards include a feature to include content from external files. This is
> described at http://www.w3.org/TR/xinclude/
> This feature is to add support for XInclude features for XML configuration
> files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
