[
https://issues.apache.org/jira/browse/SOLR-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731790#action_12731790
]
Erik Hatcher commented on SOLR-1286:
------------------------------------
I was about to commit this Jay - looks reasonable. But, the DocBuilder#commit
method sets the status of indexing completion, which won't get called as you've
patched. Looks like some slight refactoring of when that status is logged is
warranted. Also the message "Full Import completed successfully" probably
should just say "Import completed successfully" since this could be either
delta or full import.
Wanna take another round of tinkering, Jay?
A unit test that tests whether commit is called or executed would be nice, to
show the bug and the fix working - but this is straightforward enough that I'd
commit as-is. But unit tests: +1 ;)
> DIH: The commit parameter is always defaulting to "true" even if "falst" is
> explicitly passed in.
> -------------------------------------------------------------------------------------------------
>
> Key: SOLR-1286
> URL: https://issues.apache.org/jira/browse/SOLR-1286
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Reporter: Jay Hill
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-1286.patch
>
>
> I've tried running full and delta imports with commit=false so that the
> autoCommit will manage all commits to the index. However setting commit=false
> doesn't have any effect:
> curl
> 'http://localhost:8080/solr/dataimporter?command=full-import&commit=false'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
