[ 
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735751#action_12735751
 ] 

Grant Ingersoll commented on SOLR-1071:
---------------------------------------

One thought, though:

Why isn't this a JSONResponseWriter bug?  It seems to me that the code is using 
valid Solr data structures and that the problem lies in the fact that the 
JSONRW is not creating valid JSON output.  Say we fix this here in the SCC, it 
doesn't stop anyone from doing it anywhere else, which will just lead to more 
bugs later.

> spellcheck.extendedResults returns an invalid JSON response when count > 1
> --------------------------------------------------------------------------
>
>                 Key: SOLR-1071
>                 URL: https://issues.apache.org/jira/browse/SOLR-1071
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Uri Boness
>            Assignee: Grant Ingersoll
>             Fix For: 1.4
>
>         Attachments: SpellCheckComponent_fix.patch, 
> SpellCheckComponent_new_structure.patch, 
> SpellCheckComponent_new_structure_incl_test.patch
>
>
> When: wt=json & spellcheck.extendedResults=true & spellcheck.count > 1, the 
> suggestions are returned in the following format:
> "suggestions":[
>       "amsterdm",{
>        "numFound":5,
>        "startOffset":0,
>        "endOffset":8,
>        "origFreq":0,
>        "suggestion":{
>         "frequency":8498,
>         "word":"amsterdam"},
>        "suggestion":{
>         "frequency":1,
>         "word":"amsterd"},
>        "suggestion":{
>         "frequency":8,
>         "word":"amsterdams"},
>        "suggestion":{
>         "frequency":1,
>         "word":"amstedam"},
>        "suggestion":{
>         "frequency":22,
>         "word":"amsterdamse"}},
>       "beak",{
>        "numFound":5,
>        "startOffset":9,
>        "endOffset":13,
>        "origFreq":0,
>        "suggestion":{
>         "frequency":379,
>         "word":"beek"},
>        "suggestion":{
>         "frequency":26,
>         "word":"beau"},
>        "suggestion":{
>         "frequency":26,
>         "word":"baak"},
>        "suggestion":{
>         "frequency":15,
>         "word":"teak"},
>        "suggestion":{
>         "frequency":11,
>         "word":"beuk"}},
>       "correctlySpelled",false,
>       "collation","amsterdam beek"]}}
> This is an invalid json as each term is associated with a JSON object which 
> holds multiple "suggestion" attributes. When working with a JSON library only 
> the last "suggestion" attribute is picked up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to