[
https://issues.apache.org/jira/browse/SOLR-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744818#action_12744818
]
Grant Ingersoll commented on SOLR-1367:
---------------------------------------
What's hard to understand about a callback mechanism? It's akin to FileFilter
for File.listFiles or similar things.
Also, why would two loops over the same list be the same performance as one? I
suppose in the rows=10 or so case, it is in the noise, but, but if someone were
getting deeper results than say 10, the Modifier approach would be faster.
Now multiply the need to do this for every query and I think it would add up.
The whole use case is very much a special case. Most people in most situations
don't need to do this. But when you do need to do it, you do it all the time
and you want it to be fast. That being said, people can implement it
themselves. I just figured since the docListToSolrDocList method was already
there, it would be a time saver.
> Provide Callback mechanism for SolrPluginUtils.docListToSolrDocumentList
> ------------------------------------------------------------------------
>
> Key: SOLR-1367
> URL: https://issues.apache.org/jira/browse/SOLR-1367
> Project: Solr
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-1367.patch
>
>
> Sometimes SearchComponents need to modify the DocList. Often times this
> requires two loops over the (Solr)DocList: once to convert the DocList to
> SolrDocList and then once to iterate the SolrDocList for the Search
> Component. This can be seen in SOLR-773, for example.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
