[ 
https://issues.apache.org/jira/browse/SOLR-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751638#action_12751638
 ] 

Shalin Shekhar Mangar commented on SOLR-1406:
---------------------------------------------

bq. I could extend FileListEntityProcessor if it was written in a more 
extensible way, for example, exposing it's baseUrl and fileName private members 
with accessor methods, and refactoring some of the private methods that do 
fileName filtering so that they are reusable and protected.

Ah, I see. Well, that is easier than exposing DataConfig. DataConfig was never 
really meant to be exposed. We need to have another look at DataConfig before 
exposing making it a public API. How about you create an issue (or rename this 
one) to make FileListEntityProcessor more extensible rather than exposing 
DataConfig? We can get that in for 1.4.

> Add ability to retrieve DataConfig from dataimport Context
> ----------------------------------------------------------
>
>                 Key: SOLR-1406
>                 URL: https://issues.apache.org/jira/browse/SOLR-1406
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Luke Forehand
>            Assignee: Noble Paul
>         Attachments: SOLR-1406.patch
>
>
> The ability to retrieve the DataConfig is very useful for inspecting 
> configuration attributes within an EventListener!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to