[
https://issues.apache.org/jira/browse/SOLR-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760836#action_12760836
]
Hoss Man commented on SOLR-1167:
--------------------------------
bq. Detecting that there are xinclude elements present seems much harder since
that is all handled by the XML parser. How about if a warning log message is
generated if setXIncludeAware can't be set?
It occured to me that setNamespaceAware(true) has no documented failure case -
every DBF implementation is suppose to support it. So as long as the
DocumentBuilder is namespace aware, then if setXIncludeAware(true) fails, we
could (in theory) inspect the resulting DOM Document to see if there are any
"{http://www.w3.org/2001/XInclude}include"; nodes in the document -- if there
are then the config was expecting XInclude support and we can fail with a hard
error, if not then they didn't care about XInclude support anyway, so no need
to log a warning if it's not supported
(I'm just throwing this out there as an idea -- if someone wants to try
implementing it then great, but i don't think it should be a roadblock for the
existing patch, because honestly: as long as we document that XInclude depends
on XML parser support, then if people add XIncludes to their configs, but don't
test to verify that it's working in environment they're on their own and i
won't feel bad if something fails silently)
> Support module xml config files using XInclude
> ----------------------------------------------
>
> Key: SOLR-1167
> URL: https://issues.apache.org/jira/browse/SOLR-1167
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.4
> Reporter: Bryan Talbot
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-1167.patch, SOLR-1167.patch, SOLR-1167.patch,
> SOLR-1167.patch
>
>
> Current configuration files (schema and solrconfig) are monolithic which can
> make maintenance and reuse more difficult that it needs to be. The XML
> standards include a feature to include content from external files. This is
> described at http://www.w3.org/TR/xinclude/
> This feature is to add support for XInclude features for XML configuration
> files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
