[ https://issues.apache.org/jira/browse/SOLR-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781282#action_12781282 ]
Ryan McKinley commented on SOLR-1589: ------------------------------------- | But SolrException != HttpRequestException, right? More, it's not a ServletContainerException. It's a SolrException +1, I think it would be good to have some more descriptive exceptions then just the HTTP ones. But I think any new exception classes should extend SolrException with a reasonable code. That is, "InvalidFieldException extends SolrException( BAD_REQUEST )" or something like that. This way HTTP error codes will get passed correctly, OR the exception can be caught and dealt with. > Make FieldType#toInternal throw explicit Exceptions when Field values don't > validate > ------------------------------------------------------------------------------------ > > Key: SOLR-1589 > URL: https://issues.apache.org/jira/browse/SOLR-1589 > Project: Solr > Issue Type: Improvement > Affects Versions: 1.4 > Environment: My MacBook pro laptop. > Reporter: Chris A. Mattmann > Priority: Minor > Fix For: 1.5 > > > As discussed on the mailing list: > http://mail-archives.apache.org/mod_mbox/lucene-solr-dev/200911.mbox/%3c85641490-9e70-41b3-a32e-22935b688...@apache.org%3e > I think we can do a better job of having explicit Exceptions when there is a > problem creating the internal representation of a Field, as defined by > FieldType#toInternal. Instead of throwing obscure RuntimeExceptions, let's > create a FieldValidationException explicit type, and make > o.a.solr.schema.FieldType#toInternal throw this Exception as part of its > signature. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.