[
https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781294#action_12781294
]
Chris A. Mattmann commented on SOLR-1591:
-----------------------------------------
I don't get it. If someone passes in a null attribute, this method does
nothing. It simply returns. What's the point? You don't get any feedback it's
null in that case even and it just wastes a function call? I actually ran into
this while trying to write XML output for this georss stuff (accidentally
passed in a null ns attr and SOLR was all quiet on the western front...)
> XMLWriter#writeAttr silently ignores null attribute values
> ----------------------------------------------------------
>
> Key: SOLR-1591
> URL: https://issues.apache.org/jira/browse/SOLR-1591
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Environment: My local MacBook pro laptop.
> Reporter: Chris A. Mattmann
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1591.Mattmann.112209.patch.txt
>
>
> XMLWriter#writeAttr checks for val == null, and if so, does nothing. Instead
> of doing nothing, it could leverage its method signature, and throw an
> IOException declaring that the value provided is null. Patch, attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
