[
https://issues.apache.org/jira/browse/SOLR-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789926#action_12789926
]
Mark Miller commented on SOLR-1621:
-----------------------------------
bq. The setSolrConfigFilename() did not work for multicore .
But it did work for single core, and we are emulating that. I agree that it
should be removed, but perhaps not in how. I think it should go away with
warning - and I don't think we should mark something as deprecated when it just
no longer works - deprecation means the method should still work. Also, I'm not
sure if you have realized it yet, but tests currently rely on this
functionality - it cannot be pulled without replacing the functionality for
tests in some manner.
bq. So it does not make sense for us to bend over backwards to make it work in
this and add too many overloaded methods.
It doesn't require bending over backwards. It doesn't even require overloaded
methods (see my latest patch) - that was just one method.
bq. Anyway, users won't need
Its not about users needing this - they won't need it because they can now use
solr.xml - its about functionality that someone is currently counting on simply
disappearing. Personally, I'd prefer a form of deprecation first. At a minimum,
it needs to be its own issue so that the warning to users that they need to
change what they are doing is *very* clear.
> Allow current single core deployments to be specified by solr.xml
> -----------------------------------------------------------------
>
> Key: SOLR-1621
> URL: https://issues.apache.org/jira/browse/SOLR-1621
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.5
> Reporter: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch,
> SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch, SOLR-1621.patch,
> SOLR-1621.patch, SOLR-1621.patch
>
>
> supporting two different modes of deployments is turning out to be hard. This
> leads to duplication of code. Moreover there is a lot of confusion on where
> do we put common configuration. See the mail thread
> http://markmail.org/message/3m3rqvp2ckausjnf
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
