Hi,

I'm reading the source of BaseDistributedSearchTestCase, with this method:

  public void testDistribSearch() throws Exception {
    for (int nServers = 1; nServers < 2; nServers++) {
      createServers(nServers);
      RandVal.uniqueValues = new HashSet(); //reset random values
      doTest();
      destroyServers();
    }
  }

In the only test case that uses this abstract class, TestDistributedSearch, this method is not overridden, so if I'm reading it right we never really test distributed search with nServers > 1.

IMHO we should use at least 2 servers, otherwise this test doesn't make sense.

--
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com

Reply via email to