[ https://issues.apache.org/jira/browse/SOLR-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794693#action_12794693 ]
Chris A. Mattmann edited comment on SOLR-1586 at 12/27/09 4:31 PM: ------------------------------------------------------------------- Hi Grant: bq. What's the bug here? Your last patch referenced StrFieldSource in the GeoHashField class we developed: {code} + @Override + public ValueSource getValueSource(SchemaField field, QParser parser) { + return new StrFieldSource(field.name); + } + {code} Of course, StrFieldSource is a private class defined in StrField in the o.a.solr.schema package. This led me to take a look and realize that the FieldSources are really defined inconsistently (check out SOLR-1688, patch available). Cheers, Chris was (Author: chrismattmann): Hi Grant: bq. What's the bug here? Your last patch referenced StrFieldSource in the GeoHashField class we developed: {code} + @Override + public ValueSource getValueSource(SchemaField field, QParser parser) { + return new StrFieldSource(field.name); + } + {code} Of course, StrFieldSource is a private class defined in StrField in the o.a.solr.schema package. This led me to take a look at realize that the FieldSources are really defined inconsistently (check out SOLR-1688, patch available). Cheers, Chris > Create Spatial Point FieldTypes > ------------------------------- > > Key: SOLR-1586 > URL: https://issues.apache.org/jira/browse/SOLR-1586 > Project: Solr > Issue Type: Improvement > Reporter: Grant Ingersoll > Assignee: Grant Ingersoll > Priority: Minor > Fix For: 1.5 > > Attachments: examplegeopointdoc.patch.txt, SOLR-1586-geohash.patch, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112209.geopointonly.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112409.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.112509.geopointandgeohash.patch.txt, > SOLR-1586.Mattmann.120709.geohashonly.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outarr.patch.txt, > SOLR-1586.Mattmann.121209.geohash.outstr.patch.txt, > SOLR-1586.Mattmann.122609.patch.txt, SOLR-1586.patch > > > Per SOLR-773, create field types that hid the details of creating tiers, > geohash and lat/lon fields. > Fields should take in lat/lon points in a single form, as in: > <field name="foo">lat lon</field> -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.