[ 
https://issues.apache.org/jira/browse/SOLR-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794806#action_12794806
 ] 

Mark Miller commented on SOLR-1647:
-----------------------------------

bq. But the question is do we have to be that strict about everything?

Personally, I would say no, we don't (and many times we have not been). I'm not 
-1'ing the removal of this. I think we should keep it and say its going away 
first, but if we didn't, I wouldn't be too upset about it.

The weight of my opposition comes from: you said your about to commit it but 
there is no evidence of what your going to do about warning users - you are 
removing a feature some may currently be counting on - and there is no work 
around for the tests you are breaking that rely on this feature. One fails, and 
others that count on it that don't fail now, will confuse people when they try 
and change the config for the tests, but the specified config is not actually 
being used.

> Remove the option of setting solrconfig from web.xml
> ----------------------------------------------------
>
>                 Key: SOLR-1647
>                 URL: https://issues.apache.org/jira/browse/SOLR-1647
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1647.patch
>
>
> with SOLR-1621 , it is not required to have an option to set solrconfig from 
> web.xml. Moreover editing web.xml means hacking solr itself. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to