[
https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796185#action_12796185
]
Chris A. Mattmann commented on SOLR-1602:
-----------------------------------------
bq. I bet 99% of the users do not care about a wrongly named package when
everything works. But they care when things stop working. Code organization is
secondary to usability. Let us not cause discomfort to our users for such a
trivial issue.
I wouldn't be so quick to bet what 99% of your "users" think without some solid
evidence to back that up. And no, code organization is not second to usability
to all parties -- it depends on what hat you're using. To you it may be, but
not to everyone.
bq. End users do not dictate code level organization but they do have an
influence when compatibility is involved. In this case, it is an inconvenience
for many of them which can be avoided easily, so why not?
Because satisfying end-users is only looking at one of the stakeholders of the
system and ignoring the others.
bq. I agree with Hoss. This is too much discussion over too small an issue. I
think things are quite clear. Hoss, Erik, Noble and I all feel that breaking
compatibility is not worth it. So lets do what needs to be done and get on with
more important things.
The issue is far from clear as far as I'm concerned and I'm the one who
reported the issue. The comments on this issue from others are evidence of
that. The issue will be satisfied when there is clear consensus from the
parties involved.
> Refactor SOLR package structure to include o.a.solr.response and move
> QueryResponseWriters in there
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-1602
> URL: https://issues.apache.org/jira/browse/SOLR-1602
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: independent of environment (code structure)
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1602.Mattmann.112509.patch.txt,
> SOLR-1602.Mattmann.112509_02.patch.txt, upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are
> curiously located in the o.a.solr.request package. Not only is this package
> getting big (30+ classes), a lot of them are misplaced. There should be a
> first-class o.a.solr.response package, and the response related classes
> should be given a home there. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
