[ https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796529#action_12796529 ]
Noble Paul commented on SOLR-1682: ---------------------------------- bq. But now also a search is done twice. Shouldn't it be better to have two complete distinct collectors that don't depend on one another? Both the collectors are designed to complement each other so that one can piggyback on other and minimize the code/work bq. The field group.numFound is then added as well. Why did you gave it a different name? The names are up for debate . Let us reach a consensus on that . When collapse.threshhold=1 collapse.cout/collapse.groupSize can be avoided > Implement CollapseComponent > --------------------------- > > Key: SOLR-1682 > URL: https://issues.apache.org/jira/browse/SOLR-1682 > Project: Solr > Issue Type: Sub-task > Components: search > Reporter: Martijn van Groningen > Assignee: Shalin Shekhar Mangar > Fix For: 1.5 > > Attachments: field-collapsing.patch, SOLR-1682.patch, SOLR-236.patch > > > Child issue of SOLR-236. This issue is dedicated to field collapsing in > general and all its code (CollapseComponent, DocumentCollapsers and > CollapseCollectors). The main goal is the finalize the request parameters and > response format. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.