[
https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797542#action_12797542
]
Hoss Man commented on SOLR-1602:
--------------------------------
bq. instead of using the FQN of classes we should use the
solr.<SimpleClassname> notation in solrconfig.xml. That would have enabled us
moving packages easily
I've been biting my tounge on that aspect of things. Once upon a time, in the
early days of incubation, the example config didn't contain any FQNs, but there
were some vocal people arguing that it was missleading to suggest that a
"class" named "solr.Foo" existed (the implication being that it would confuse
users who understood java and expected that to be a real class/package name.
I'm more then happy to switch back to using "solr.Foo" everywhere in the
example configs, but there have also been some threads out there in the past
pointing out that using FQNs can speed up core initialization (when people are
dynamicly creating lots of cores) so we shouldn't/can't ever assume that people
are *only* using solr.Foo even if that's all we start using in the examples.
And lastly...
bq. well, technically, in the solrconfig.xml that we distribute to the world,
the one kitchen sink example solrconfig.xml, they're all commented out and
pre-registered. so it's just an "example".
... _most_ of them are commented out, not all.
Besides which: even if it's just an "example" it would be pretty shitty to
break that example in the very next release.
> Refactor SOLR package structure to include o.a.solr.response and move
> QueryResponseWriters in there
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-1602
> URL: https://issues.apache.org/jira/browse/SOLR-1602
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: independent of environment (code structure)
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1602.Mattmann.112509.patch.txt,
> SOLR-1602.Mattmann.112509_02.patch.txt, upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are
> curiously located in the o.a.solr.request package. Not only is this package
> getting big (30+ classes), a lot of them are misplaced. There should be a
> first-class o.a.solr.response package, and the response related classes
> should be given a home there. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
