[ 
https://issues.apache.org/jira/browse/SOLR-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842380#action_12842380
 ] 

Noble Paul commented on SOLR-1798:
----------------------------------

bq.do you remember why a List was used here?

It was used to collect the cumulative data. I guess the original LRU cache was 
doing it the same way. It was a wrong decision to make

> Memory leak in FastLRUCache
> ---------------------------
>
>                 Key: SOLR-1798
>                 URL: https://issues.apache.org/jira/browse/SOLR-1798
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.4, 1.5
>            Reporter: Laxman
>            Assignee: Yonik Seeley
>             Fix For: 1.5
>
>         Attachments: SOLR-1798.patch, SOLR-1798.patch
>
>
> Every time a commit happens two Stats instances 
> [org.apache.solr.common.util.ConcurrentLRUCache.Stats] are leaking.
> Following code [org.apache.solr.search.FastLRUCache] to maintain cumulative 
> cache statistics causing this Stats object leak. 
> {noformat}
>     cumulativeStats = (List<ConcurrentLRUCache.Stats>) persistence;
>     cumulativeStats.add(cache.getStats());
> {noformat}
> Everytime a *commit* happens a new cache object is getting created and its 
> stats is added to the list which is not released at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to