On Jan 31, 2007, at 3:21 AM, Antonio Eggberg wrote:
Hi:
Two questions ..
I am wondering about the following in the file solrb/lib/solr/
connection.rb we are doing http post
{ "Content-Type" => "application/x-www-form-urlencoded;
charset=utf-8" })
however the file under example/exampledocs/post.sh is using
Content-type:text/xml; charset=utf-8
I would like to know why? to my understanding application/x-www is
under FORM submission.. no?
This feels like a bug, is it ticketed? Solr::Request::Select requests
are POSTing URL encoded name/value pairs so the Content-type is
appropriate...But Solr::Request::AddDocument (and others) are posting
xml so the Content-type should be text/xml. There needs to be logic
for differentiating between the two.
In the file solrb/lib/solr/request/select.rb we are using
ERB::Util in line ..
if value.respond_to? :each
value.each { |v| http_params << "#{key}
=#ERB::Util::url_encode(v)}" unless v.nil?}
else
http_params << "#{key}=#{ERB::Util::url_encode(value)}"
unless value.nil?
Shouldn't the above needs to html_escape ?? no ?? Could you please
explain.
In this case the values need to be URL encoded because of the Content-
Type for posting a select request. So I don't see a problem here.
//Ed
