On 2/6/07, Erik Hatcher <[EMAIL PROTECTED]> wrote:
On Feb 5, 2007, at 11:50 PM, Mel Riffe wrote: > I have a first pass at getting the test server to come up in a win32 > environment. Fantastic! Now both of you will soon be able to test solrb on Windows ;) > So I would like to know how to submit a patch. Pleasantly enough, we have this: <http://wiki.apache.org/solr/ HowToContribute>
Thanks! Hopefully tonight... For solrb, patches rooted from the solrb directory are cleaner for me.
> 1) Failure: > test_bad_connection(ServerTest) [./test/functional/server_test.rb:78]: > <Errno::ECONNREFUSED> exception expected but was > Class: <Errno::EBADF> > Message: <"Bad file descriptor - connect(2)"> This test has been brittle, I believe. We can adjust it to be more lenient and simply assert we get an exception thrown. This test in particular is not really testing much of importance, since pointing solrb to a bad Solr URL is gonna be bad news no matter what. But making the exception it checks for more lenient should be fine. > 2) Failure: > test_ping(ServerTest) [./test/functional/server_test.rb:96]: > <true> expected but was > <false>. hmmm... odd. I don't have an explanation for this one. What is the ping request returning? Fire up Solr and hit /admin/ping to see what is returned.
Can do! Thanks for your effort on this. Despite my joke above, Windows
support is important.
Actually there are three Windows users: Me, Myself and I. ;-) Cheers, Mel Erik