On Tue, Nov 10, 2015, at 04:22 PM, Yago Riveiro wrote:
> Patch attached to https://issues.apache.org/jira/browse/SOLR-8065
> 
> 
> 
> 
> 
> The windows script is voodo for me :D, I haven’t the knowledge to port
> this to cmd script.

Great! I saw this!

Two things - firstly, when making a patch, please try to avoid
whitespace changes. The only changes that should show in the diff should
be material changes.

Secondly - I think there was a suggestion that this change could be
ported *inside* the SolrCLI - i.e. into Java code. Do you reckon you
could handle that change? Harder than just updating a shell script, I
know, but could be very useful.

Upayavira

Reply via email to