Nothing that I know of was _intentionally_ changed with this between 6x and 7x. That said, nothing that I know of was done to verify that TLOG and PULL replicas (added in 7x) were handled correctly. There's a test "TestRebalanceLeaders" for this functionality that has run since the feature was put in, but it has _not_ been modified to create TLOG and PULL replicas and test with those.
For this patch to be complete, we should either extend that test or make another that fails without this patch and succeeds with it. I'd probably recommend modifying TestRebalanceLeaders to randomly create TLOG and (maybe) PULL replicas so we'd keep covering the various cases. Best, Erick On Thu, Dec 20, 2018 at 8:06 AM Bernd Fehling <bernd.fehl...@uni-bielefeld.de> wrote: > > Hi Vadim, > I just tried it with 6.6.5. > In my test cloud with 5 shards, 5 nodes, 3 cores per node it missed > one shard to become leader. But noticed that one shard already was > leader. No errors or exceptions in logs. > May be I should enable debug logging and try again to see all logging > messages from the patch. > > Might be they also changed other parts between 6.6.5 and 7.6.0 so that > it works for you. > > I also just changed from zookeeper 3.4.10 to 3.4.13 which works fine, > even with 3.4.10 dataDir. No errors no complains. Seems to be compatible. > > Regards, Bernd > > > Am 20.12.18 um 12:31 schrieb Vadim Ivanov: > > Yes! It works! > > I have tested RebalanceLeaders today with the patch provided by Endika > > Posadas. > > (http://lucene.472066.n3.nabble.com/Rebalance-Leaders-Leader-node-deleted-when-rebalancing-leaders-td4417040.html) > > And at last it works as expected on my collection with 5 nodes and about > > 400 shards. > > Original patch was slightly incompatible with 7.6.0 > > I hope this patch will help to try this feature with 7.6 > > https://drive.google.com/file/d/19z_MPjxItGyghTjXr6zTCVsiSJg1tN20 > > > > RebalanceLeaders was not very useful feature before 7.0 (as all replicas > > were NRT) > > But new replica types made it very helpful to keep big clusters in order... > > > > I wonder, why there is no any jira about this case (or maybe I missed it)? > > Anyone who cares, please, help to create jira and improve this feature in > > the nearest releaase > >
