On Fri, Mar 13, 2009 at 9:56 PM, Jon Baer <jonb...@gmail.com> wrote: > Bare in mind (and correct me if Im wrong) but a "full-import" is still a > "full-import" no matter what entity you tack onto the param. > > Thus I think clean=false should be appended (a friend starting off in Solr > was really confused by this + could not understand why it did a delete on > all documents). > > Im not sure if that is clearly stated in the Wiki ... >
Yes it is confusing and even more now that we have preImportDeleteQuery. For a full-import command, the default is clean=true. If clean=false is specified, then no cleanup is done (not even pre/postImportDeleteQuery). Even if there is a pre/postImportDeleteQuery, if the first root entity does not have a preImportDeleteQuery then all documents are deleted (which I guess is a bug). For a delta-import command, the default is clean=false (and no pre/postImportDeleteQuery is run). I think we should open an issue to figure out and implement an acceptable behavior before we release 1.4 -- Regards, Shalin Shekhar Mangar.
