Adding PCM Float support into current WaveFileReader.java, WaveFileWriter.java would be best. And it is just question of adding few lines. But until then I think you can use WaveFloatFileReader.java, WaveFloatFileWriter.java. ________________________________________ Frá: [EMAIL PROTECTED] [EMAIL PROTECTED] Sent: 29. júlí 2008 00:25 Viðtakandi: Alex Menkov; Karl Helgason Afrit: sound-dev@openjdk.java.net; [EMAIL PROTECTED]; [EMAIL PROTECTED] Efni: Re: <Sound Dev> Updating Gervill for OpenJDK 6 build 12
Alex Menkov wrote: > > Karl Helgason wrote: >>>> WaveExtensibleFileReader,WaveFloatFileWriter,WaveFloatFileReader >>>> has been >>>> moved to src.floatwav in the Gervill CVS. Because they aren't >>>> directly related with >>>> Gervill Synthesizer. They simply add support for float encoded Wave >>>> files. >>>> And WaveExtensibleFileReader is also a proposal how we should store >>>> channel mask in AudioFormat properties (used for multi-channel wave >>>> files). >>> So, should I add these files to OpenJDK 6? >>> >> >> It depends, Alexey thought we should rather add support for PCM Float >> support >> to current com.sun.media.sound.WaveFileReader and WaveFileWriter classes >> than introducing new one. > > All this wave readers (current PCM/ALAW/ULAW and Float & Extensible > from Gervill) could be combined in different ways - basing on current > WaveFileReader or basing on WaveFloatFileReader or > WaveExtensibleFileReader. > Main goal is to avoid functionality duplication. I'm personally agnostic toward how this functionality is implemented. Alex and Karl, how about I add these files along with the other changes I'm making? -Joe > > >>> And WaveExtensibleFileReader is also a proposal how we should store > >>> channel mask in AudioFormat properties (used for multi-channel > wave files). > > Wow.. I've overlooked this :) > > > > Regards > Alex No virus found in this incoming message. Checked by AVG. Version: 7.5.524 / Virus Database: 270.5.6/1576 - Release Date: 27.7.2008 16:16