Re: JDK 9 RFR of JDK-8042871: Fix raw and unchecked warnings in sun.audio

[Sergey Bylokhov]

Hi, Joe.
The fix looks good.

On 16.05.2014 20:46, Joe Darcy wrote:

On 05/15/2014 12:16 PM, Sergey Bylokhov wrote:

Hi. Joe.
It seems to me "Enumeration e" in AudioStreamSequence can be removed too.

Hi Sergey,

Actually it seems both variables in the class can be removed:

--- a/src/share/classes/sun/audio/AudioStreamSequence.java Wed May 14 18:19:14 2014 +0400 +++ b/src/share/classes/sun/audio/AudioStreamSequence.java Fri May 16 09:44:17 2014 -0700

@@ -44,16 +44,11 @@
  * @author Arthur van Hoff
  */
 public final class AudioStreamSequence extends SequenceInputStream {
-
-        Enumeration e;
-        InputStream in;
-
         /**
          * Create an AudioStreamSequence given an
          * enumeration of streams.
          */
-        public AudioStreamSequence(Enumeration e) {

+ public AudioStreamSequence(Enumeration<? extends InputStream> e) {

             super(e);
         }
-
-    }
+}

Updated webrev

http://cr.openjdk.java.net/~darcy/8042871.1/

Thanks,

-Joe

On 5/15/14 10:08 AM, Joe Darcy wrote:

Hello,

Please review this fix for

    JDK-8042871: Fix raw and unchecked warnings in sun.audio
http://cr.openjdk.java.net/~darcy/8042871.0/

Patch below.

Thanks,

-Joe

--
Best regards, Sergey.