The fix looks good to me.
Thanks,
Alexander.
On 09/17/2014 09:45 PM, Sergey Bylokhov wrote:
On 17.09.2014 21:28, Phil Race wrote:
No real problems but I wonder why you made unsupportedDevice declare
RuntimeException
but actually throw IAE
It is shorer, plus decrease the size of the classfiles a little bit,
where this small utility method is used.
and why you split the test in two ?
I just write one of them and another one after. I can merge them.
-phil.
On 9/17/14 5:42 AM, Sergey Bylokhov wrote:
Hello.
Any volunteers?
On 10.09.2014 19:46, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 9.
Changes description:
- SoftProvider.java/ RealTimeSequencerProvider.java: getDevice now
does not return null for unsupported devices + small cleanup.
- MidiDeviceProvider.java: isDeviceSupported now does not throw
unspecified NPE in case of null parameter.
- AbstractMidiDeviceProvider.java: getDevice now does not throw
unspecified NPE in case of null parameter.
- MidiSystem.java: small cleanup of a related to MidiDevice methods.
In some places the String.format now used instead of string
concatenation in non performance critical code to make class file
smaller.
Bug: https://bugs.openjdk.java.net/browse/JDK-8058115
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8058115/webrev.00
