----- Original Message ----- > Hello, > > Build change looks good to me. Nice to see this big chunk logic removed. > > /Erik > > On 2015-02-09 17:10, Sergey Bylokhov wrote: > > Hello. > > Please review a fix for jdk 9. > > Unused method was removed. See additional information in bug description. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8072665 > > Webrev can be found at: > > http://cr.openjdk.java.net/~serb/8072665/webrev.00 > > > >
+1 Great to see this go. Every new architecture has had to update SoundLibraries.gmk (and its earlier equivalent in <= 7), resulting in probably twice as many such definitions in IcedTea where we build on more architectures. Removing this thus removes one barrier to new OS/arch ports. X_ARCH seems to be clearly unused, given ppc64 sets it to X_PPC64, but X_PPC64 is never given a value in SoundDefs.h. -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
