Looks fine.
Thanks,
Alexander.
On 09/23/2015 07:03 PM, Sergey Bylokhov wrote:
Hi, Alexander.
After some time, I have a fix for this:
http://cr.openjdk.java.net/~serb/6646604/webrev.00
Note that most of the typos in the swing code were fixed already. I
also tries to split long lines but as usual these html files use such
style a lot.
On 23.07.14 14:47, Alexander Zvegintsev wrote:
Hi Sergey,
here is the list where I've found trailing dots:
midi/MidiDevice.java:338
midi/SysexMessage.java:127
midi/Synthesizer.java:347
sampled/LineEvent.java:85
sampled/AudioInputStream.java:395
Otherwise the fix looks good to me.
Thanks,
Alexander.
On 07/23/2014 01:44 PM, Sergey Bylokhov wrote:
Hello,
Any volunteers to be a second reviewer?
On 17.07.2014 12:18, Petr Pchelko wrote:
Hello, Sergey.
The fix looks good to me.
With best regards. Petr.
On 16 июля 2014 г., at 20:56, Sergey Bylokhov
<sergey.bylok...@oracle.com> wrote:
Hello.
Please review another one javadoc cleanup in jdk 9 in sound area:
- @param, @return should not end with a dot, except a case when more
than one sentences are used.
- @param, @throws, @return now align, to be more readable.
- @see tags simplified in some places.
- Description of the class/method/field should be followed by dot.
- Broken links/typos fixed
- 80 column limit.
- sets of spaces in the middle of text were deleted.
- <tag> replaced by {@tag }.
- unnecessary imports were removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8050852
See the full specdiff:
http://cr.openjdk.java.net/~serb/8050852/javadoc/overview-summary.html
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8050852/webrev.02
--
Best regards, Sergey.
