This all looks fine to me. Given the nature of the changes (if it
passes javac it should be fine) I think one review is enough.
Approved.
-phil.
On 8/12/16, 7:19 AM, Sergey Bylokhov wrote:
Hello, Audio Guru.
Please review cleanup of JavaSound classes in jdk9, which is result of
my ongoing cleanup of JavaSound API.
- @Override was applied to lots of methods.
- Useless comments like /**Old code*/ were removed.
- The final keyword was added to some fields.
- The empty lines usage was unified.
- The usage of "import" was unified/cleaned as well
- Unnecessary casts were removed.
- The diamond operator now used insteaf types for example:(new
HashMap<String, Object> was changed to new HashMap<>, etc)
Since webrev became huge I postpone other possible cleanups.
No regressions were found by jtreg/jck tests.
Bug: https://bugs.openjdk.java.net/browse/JDK-8163949
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8163949/webrev.01
