Best, Florian

On 11.10.2016 13:36, Alex Menkov wrote:
Looks good.


On 10.10.2016 20:35, Sergey Bylokhov wrote:
Hello, Audio Guru.

Please review the fix for jdk9.

According the specification of Clip.open(AudioFormat,byte[], int, int):
     * @throws IllegalArgumentException if the buffer size does not
represent an
     * integral number of sample frames
    void open(AudioFormat format, byte[] data, int offset, int

We have two implementations of the Clip.
 - In SoftMixingClip  exception is thrown
 - In DirectAudioDevice  exception is not thrown

DirectAudioDevice was fixed, the check was moved to the utility method.

No regressions were found by jtreg/jck tests.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
Webrev can be found at:

Florian Bomers
Bome Software

everything sounds.
Bome Software GmbH & Co KG        Gesellschafterin:
Dachauer Str.187                  Bome Komplementär GmbH
80637 München, Germany            Geschäftsführung: Florian Bömers
Amtsgericht München HRA95502      Amtsgericht München HRB185574

Reply via email to