Hi Sergey, +1 ! Very happy to see “final” and “closable” used. I very much like that pattern.
Dan > On Dec 8, 2017, at 8:19 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > Hello, Audio Guru. > Please review the fix for jdk10. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8178401 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8178401/webrev.01 > > Description: > Most of our audio file writers can try to convert the saved audio stream to > the format which is supported by the current writer, for example it can > convert big<->little-endian, signed/unsigned, etc. Because of unsupported > conversion (or because of some other reasons) we can get some exceptions. In > this case we have to close all streams, because such streams can lock the > file on Windows. > > This particular bug is responsible for a grown number of temporary files on > our automated test systems and causes some intermittent failures. > > -- > Best regards, Sergey.
