1) Thanks for uploading the webrev. much better for one person to do
this than make
everyone who wants to look at it go through a tedious and off-putting
set of steps.
2) I've added some client lists since you are touching UI client files,
not just core-libs.
To me the client ones look OK, one looks more like it was a typo
than anything intentional,
and the other was pretty mild.
3) Regarding the comment in the bug report about hb-private.hh and the
use of
/* CRAP pool: Common Region for Access Protection. */
since it not only is in an upstream library, but also used 14 times in
variable names,
then I can't possibly agree with your comment that an argument for
leaving them
would be "shaky". Take this up with the upstream library ... I have no
interest in
renaming these every time we upgrade this library.
-phil.
On 12/11/18 8:45 AM, Adam Farley8 wrote:
Sure thing:
http://cr.openjdk.java.net/~afarley/8215217/webrev/
Best Regards
Adam Farley
IBM Runtimes
Volker Simonis <volker.simo...@gmail.com> wrote on 11/12/2018 15:46:44:
From: Volker Simonis <volker.simo...@gmail.com>
To: adam.far...@uk.ibm.com
Cc: Java Core Libs <core-libs-...@openjdk.java.net>
Date: 11/12/2018 15:47
Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words
Hi Adam,
in order to prevent me from using swear words, could you please upload
your webrev to cr.openjdk.java.net :)
As you may have realized webrevs are a collection of HTML files and it
makes no big sense to provide them as a zip file.
Thank you and best regards,
Volker
On Tue, Dec 11, 2018 at 4:04 PM Adam Farley8 <adam.far...@uk.ibm.com>
wrote:
Hey All,
I've spotted 12 instances of swear words in OpenJDK source comments,
and
it seems appropriate to remove them.
Bug: INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8215217&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf-
CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=GfAb5QlDParO6DVrhdvPZTSafShnFACNF3JgqF-
_RkM&s=Qscaf2tTpPcZKpIelJ6SrP0uRYSFoKaCNATns0FX7_Y&e=
I've created a webrev and attached to the bug.
Also, I've mentioned in the bug that there are additional swears in
more
excusable locations. It would be good to get the community's take on
those.
Reviews and opinions welcome. :)
Best Regards
Adam Farley
IBM Runtimes
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with
number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
