Thanks for the help. Sorry, I used the plural form, when I should have used the singular form. In libjsound there is only one case - there were other issues in the rest of the OpenJDK code...
I will also Thanks, -Andrew From: Phil Race <philip.r...@oracle.com> Sent: Thursday, May 16, 2019 10:12 AM To: Andrew Luo <andrewluotechnolog...@outlook.com>; sound-dev@openjdk.java.net Subject: Re: <Sound Dev> [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) First thing you need is a bug : https://bugs.openjdk.java.net/browse/JDK-8224056 Second is a sponsor. I can help there. Can you resubmit with your patch in-line (not an attachment) and the subject line: RFR: 8224056: Fix some assignments of string literals to LPSTR (instead of LPCSTR) You said "a few issues" and "some of these" but you only have one that I see -LPSTR TranslateDSError(HRESULT hr) { +LPCSTR TranslateDSError(HRESULT hr) { What am I missing ? I don't want a patch per case, I'd like just one patch for all of java sound. We should also test this builds in the standard mode although I don't see why it should not. -phil. On 5/13/19 5:36 PM, Andrew Luo wrote: I've been trying to get the JDK to compile with the new /permissive- switch in VS2017 (https://devblogs.microsoft.com/cppblog/permissive-switch/) however there have been a few issues in various parts of the code. There are a few issues in the libjsound code where we attempt to assign string literals to LPSTR variables (instead of LPCSTR). I took some time to fix some of these and attached a patch. Let me know if you have any comments/feedback. I'm assuming that libjsound is owned by sound-dev, but if I'm mistaken, please do let me know the right team/mailing list to send this to. c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' Thanks, -Andrew
